Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal rootfs target from README #38

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

otteryc
Copy link
Contributor

@otteryc otteryc commented Dec 26, 2024

The "rootfs" target was originally introduced in commit 9d5eac5: "Parse the cmdline arguments more perfectly", but was later removed in commit 25571f7: "Modularize the build system" without updates to the README or integration into mk/external.mk.

"make rootfs" is considered redundant, since the target is only intended to used internally, this commit removes its description in README to prevent confusion.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do that. The target rootfs should not exist as it is used internally.

@otteryc otteryc force-pushed the rootfs_pr branch 2 times, most recently from 1698440 to 0db4633 Compare December 26, 2024 08:27
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use backticks in git commit messages for the sake of terminal compatibility, as some terminals cannot render that character well.

Change the subject of this pull request as well.

The "rootfs" target was originally introduced in commit 9d5eac5: "Parse
the cmdline arguments more perfectly", but was later removed in commit
25571f7: "Modularize the build system" without updates to the README or
integration into mk/external.mk.

"make rootfs" is considered redundant, since the target is only intend-
ed to used internally, this commit removes its description in README to
prevent confusion.
@otteryc otteryc changed the title Fix missing rootfs Makefile target Remove internal rootfs target from README Dec 26, 2024
@jserv jserv merged commit 93f1fee into sysprog21:master Dec 26, 2024
1 check passed
@jserv
Copy link
Contributor

jserv commented Dec 26, 2024

Thank @otteryc for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants