Use bus interface in the serial device #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bus interface can be used by other non-PCI MMIO and PIO devices. This pave the way for the serial device to use it.
Before this change, the VM exit handler used the hard-coded I/O port numbers to handle I/O for the serial device. This change makes the serial device registers its I/O port interface by using bus interface and removes the hard-coded I/O port numbers in the VM exit handling routine.
|
Thank @yanjiew1 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the I/O port handler checks the hard-coded I/O port range of the serial device and call the serial device I/O handler if the port number is within the range.
This pull request moves the bus interface and its implementations into dedicated files (bus.c and bus.h), changes the serial device to register its I/O port using the bus interface and removes the hard-coded port numbers in VM exit handling routine.
This fixes #10.