Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update currencies to include more currencies #81

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Update currencies to include more currencies #81

merged 1 commit into from
Jun 30, 2024

Conversation

katosdev
Copy link
Contributor

@katosdev katosdev commented Jun 30, 2024 •
edited by coderabbitai bot
Loading

What type of PR is this?

  • feature

What this PR does / why we need it:

Update the list of available currencies to include more, such as the New Zealand Dollar.
Begin refactor to allow for easier updating going forwards.

Which issue(s) this PR fixes:

#1 #79

Release Notes

Begins refactor of currencies to allow for easier syncing and management. 
Adds extended support for additional currencies.

Summary by CodeRabbit

  • New Features

    • Added new currency entries for Eastern Carribean Dollar (XCD) and CFA Franc (XOF).
    • Included New Zealand Dollar (NZD) in the currency list.

  • Updates

    • Updated the existing entry for CFA Franc BEAC (XAF) with more detailed information.

@katosdev katosdev added the ⬆️ enhancement New feature or request label Jun 30, 2024
@katosdev katosdev self-assigned this Jun 30, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 30, 2024 •
edited
Loading

Walkthrough

Walkthrough

The currencies.json file has been enhanced by adding entries for Eastern Caribbean Dollar (XCD) and CFA Franc (XOF). Additionally, New Zealand Dollar (NZD) has also been introduced. Notably, the CFA Franc BEAC (XAF) entry has been updated to reflect the correct name.

Changes

File Summary
backend/internal/core/currencies/c... Added new currency entries for Eastern Caribbean Dollar (XCD), CFA Franc (XOF), and New Zealand Dollar (NZD). Updated an existing entry for CFA Franc BEAC (XAF).

Poem

In code’s realm, new currencies arise, 🌐

With symbols gleaming like twinkling skies. ✨

East Caribbean’s dollar joins the fray, 💸

Along with CFA Franc in a bright new way. 💱

From NZ's shores to BEAC's proud name, 🏞️

In JSON's lines, they find their fame. 📜

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@katosdev katosdev mentioned this pull request Jun 30, 2024
Closed
3 tasks
coderabbitai[bot]
coderabbitai bot reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f00822 and 499bb90.

Files selected for processing (1)
  • backend/internal/core/currencies/currencies.json (2 hunks)
Additional comments not posted (4)
backend/internal/core/currencies/currencies.json (4)

20-25: Addition of Eastern Carribean Dollar (XCD) is correct.

The currency code, local name, symbol, and full name are accurately added.

26-31: Addition of CFA Franc (XOF) is correct.

The currency code, local name, symbol, and full name are accurately added.

182-187: Modification of CFA Franc BEAC (XAF) is correct.

The currency name has been accurately updated to reflect its full name.

194-199: Addition of New Zealand Dollar (NZD) is correct.

The currency code, local name, symbol, and full name are accurately added.

@katosdev katosdev merged commit ea1d922 into main Jun 30, 2024
5 checks passed
@katosdev katosdev deleted the katos/currency branch June 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@katosdev katosdev

Labels
⬆️ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@katosdev