Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the link tooltip to the top to prevent overflows #77

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

zebrapurring
Copy link
Contributor

@zebrapurring zebrapurring commented Jun 29, 2024

What type of PR is this?

  • bug

What this PR does / why we need it:

Seems like #73 didn't solve the issue for some links (I could test this on mobile devices). Moving the tooltip to the top helps in this cases.

Which issue(s) this PR fixes:

Fixes #72

Move the item field link tooltips to the top

Summary by CodeRabbit

  • Style
    • Changed the tooltip position for links in the Details Section from right to top for improved user experience.

Copy link
Contributor

coderabbitai bot commented Jun 29, 2024

Walkthrough

Walkthrough

The DetailsSection.vue component's tooltip position for links was altered from right to top to prevent the tooltip from causing page overflow issues with long links.

Changes

Files/Paths Change Summary
frontend/components/global/DetailsSection/DetailsSection.vue Tooltip position for links changed from right to top

Assessment against linked issues

Objective Addressed Explanation
Page overflow when a field contains a long link (#72) Change might help but isn't fully clear

Poem

🛠️ A shift of tooltip's gentle glide,
From right to top it now will bide.
No longer long links overflow,
Enhancing user joy and show! 🌐✨


Tip

Early access features
  • OpenAI gpt-4o model for reviews and chat.

Note:

  • You can disable early access features from the CodeRabbit UI or by setting early_access: false in the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6a1ffd7 and b6fd628.

Files selected for processing (1)
  • frontend/components/global/DetailsSection/DetailsSection.vue (1 hunks)
Files skipped from review due to trivial changes (1)
  • frontend/components/global/DetailsSection/DetailsSection.vue

@katosdev katosdev force-pushed the fix-tooltip-overflow-top branch from b6fd628 to ff28175 Compare June 29, 2024 18:51
@katosdev
Copy link
Contributor

Thanks for the contribution @zebrapurring ! ❤️

@katosdev katosdev merged commit 4f00822 into sysadminsmedia:main Jun 29, 2024
2 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b6fd628 and ff28175.

Files selected for processing (1)
  • frontend/components/global/DetailsSection/DetailsSection.vue (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • frontend/components/global/DetailsSection/DetailsSection.vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page overflow when a field contains a long link
2 participants