Remove all SIL-specific stuff #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 15.29% 15.20% -0.09%
==========================================
Files 12 12
Lines 1419 1427 +8
==========================================
Hits 217 217
- Misses 1202 1210 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kinke
force-pushed
the
mv_sil_stuff
branch
4 times, most recently
from
1fc9623
to
3de8354
Compare
It was only NOT defined for the unittest config.
|
Still need to confirm |
|
No idea how it's working in detail, but |
kinke
commented
Aug 4, 2023
| @@ -6,8 +6,9 @@ module symmetry.imap.grammar; | |||
| a PEG grammer. | |||
| +/ | |||
|
|
|||
| version (SIL) : | |||
| import pegged.grammar; | |||
| version (Have_pegged): | |||
There was a problem hiding this comment.
This unused module was previously enabled for the SIL plugin and sil-library config. Not anymore - there's the with-grammar config now instead (build tested by CI).
Its an alias to some symbol in mir IIRC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving it to SIL instead.