Make link color white. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Looks good - I was going to ask you to not use !important but this css file already uses that in a lot of places, and there's not really a clean way to handle this particular scenario, so if we didn't use !important here we'd have to trade one horror for another.
I've retargetted this PR to the 3.6 and reset commits - no change to the actual PR itself.
Will merge when CI goes green.
GuySartorelli
force-pushed
the
link_color_fix
branch
from
622f28e to
1637e78
Compare
|
This will be automatically tagged by GitHub actions. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression where the Add new record popup link is now blue.
This update overwrites the SilverStripe style (/resources/vendor/silverstripe/admin/client/dist/styles/bundle.css)
Before:
After:
