WIP: bootstrap popovers #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added DOM attach method functionality
Later versions of IE introduce a relative style applied on the element that breaks layouts.
FIX later versions of IE and relative position
Okay I don't know how I missed that one when changing it, must have been a seriously mind breaking day
… positioning issues
|
Commenting here for reference, can you please look into adding a toggle so it's possible to switch between the existing jQuery UI and Bootstrap? |
nglasl
reviewed
Jan 17, 2017
| @@ -1,44 +1,17 @@ | |||
| <% if HelpItems %> | |||
There was a problem hiding this comment.
If the current page doesn't have inline help items, you end up getting JS errors while trying to loop over an undefined variable. Can you please do something such as (outside the if statement)..
var SS_InlineHelpItems = {};
Or check whether this actually exists in the JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.