Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add AssetTransactor implementation with XCM #145

Merged
merged 31 commits into from
Feb 7, 2024
Merged

feat: Add AssetTransactor implementation with XCM #145

merged 31 commits into from
Feb 7, 2024

Conversation

freddyli7
Copy link
Contributor

@freddyli7 freddyli7 commented Nov 2, 2023 •
edited
Loading

  • Implement the AssetTransactor trait to support local recipient and the remote parachain recipient
  • Implement the XCM bridge pallet
  • Implement the bridge forwarder with trait

@freddyli7 freddyli7 linked an issue Nov 2, 2023 that may be closed by this pull request
Implement the AssetTransactor trait to support local recipient and the remote parachain recipient #133
Closed
@freddyli7 freddyli7 changed the title feat: Add AssetTransactor implementation feat: Add AssetTransactor implementation with XCM Dec 4, 2023
This was linked to issues Dec 6, 2023
Implement the transactor forwarder #134
Closed
Implement the XCM message structure, constructor with different formats #135
Closed
Implement the XCM fee logic #136
Closed
Implement the XCM executor #137
Closed
Implement the XCM handler pallet and integrate with xcm message creation logic and execution logic #138
Closed
Implement the asset forward logic #140
Closed
@freddyli7 freddyli7 self-assigned this Jan 8, 2024
tolak
tolak reviewed Jan 15, 2024
View reviewed changes
bridge/src/xcm_asset_transactor.rs Outdated Show resolved Hide resolved
bridge/src/xcm_asset_transactor.rs Outdated Show resolved Hide resolved
bridge/src/xcm_asset_transactor.rs Outdated Show resolved Hide resolved
xcm-bridge/src/lib.rs Show resolved Hide resolved
xcm-bridge/src/mock/mod.rs Show resolved Hide resolved
@freddyli7 freddyli7 marked this pull request as ready for review January 29, 2024 20:29
@freddyli7 freddyli7 requested a review from tolak January 31, 2024 15:06
tolak
tolak reviewed Feb 5, 2024
View reviewed changes
bridge-forwarder/src/xcm_asset_transactor.rs Outdated Show resolved Hide resolved
bridge-forwarder/src/xcm_asset_transactor.rs Show resolved Hide resolved
bridge-forwarder/src/lib.rs Outdated Show resolved Hide resolved
bridge/src/lib.rs Show resolved Hide resolved
xcm-bridge/src/lib.rs Show resolved Hide resolved
tolak
tolak approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@tolak tolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM

@freddyli7 freddyli7 linked an issue Feb 7, 2024 that may be closed by this pull request
Create the sygma bridge destination standard #139
Closed
@freddyli7 freddyli7 merged commit 9dd2b53 into main Feb 7, 2024
6 checks passed
@MakMuftic MakMuftic mentioned this pull request Jan 25, 2024
Open
@freddyli7 freddyli7 deleted the freddy/asset-transactor branch March 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolak tolak tolak approved these changes

Assignees

@freddyli7 freddyli7

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@freddyli7 @tolak