Introduce configuration variables #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to fix an issue that prevents Sphinx from running inside a devcontainer nektos/act#1853
Taking advantage of workspace local extensions, this adds a make target that will symlink the `code/` directory to `.vscode/extensions/esbonio` allowing it to be installed. It would be nice if there was a cli `code` command that would do the final step though....
Configuration objects can now accept variables of the form `${variable}`
and have them expanded by the configuration system at runtime.
This commit adds support for the following variables
- `${scope}`: The full uri of the scope at which the configuration
object was requested
- `${scopePath}`: The path component of the scope uri
- `${scopeFsPath}`: The path component of the scope uri as a
filesystem path
Currently these configuration variables will only be expanded if they
appear in a field that is a simple string.
Additionaly, this commit sets the default value for `SphinxConfig.cwd`
to be `${scopeFsPath}`. This should mean that any
`esbonio.sphinx.buildCommand` values in a `pyproject.toml` file will
be evaluated relative to the file's location. Closes swyddfa#711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration objects can now accept variables of the form
${variable}and have them expanded by the configuration system atruntime.
This commit adds support for the following variables
${scope}: The full uri of the scope at which the configurationobject was requested
${scopePath}: The path component of the scope uri${scopeFsPath}: The path component of the scope uri as afilesystem path
Currently these configuration variables will only be expanded if they
appear in a field that is a simple string.
Additionaly, this commit sets the default value for
SphinxConfig.cwdto be
${scopeFsPath}. This should mean that anyesbonio.sphinx.buildCommandvalues in apyproject.tomlfile willbe evaluated relative to the file's location. Closes #711