Feat: readSharedExamInfo 구현 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
테스트 커버리지 측정
|
테스트 커버리지 측정
|
adorableco
requested changes
Oct 19, 2024
| endTime = sharedExam.endTime, | ||
| capacity = sharedExam.capacity, | ||
| workbookId = sharedExam.workbook.id, | ||
| isWriter = sharedExam.member.id == memberId, |
There was a problem hiding this comment.
Suggested change
| isWriter = sharedExam.member.id == memberId, | |
| role = | |
| if (exam.member.id == memberId) { | |
| ParticipationType.CREATOR | |
| } else { | |
| ParticipationType.EXAMINEE | |
| }, |
이거 readAllSharedExams 기능이랑 통일감있게 이렇게 수정하는 거 어떨까욘 ExamDto 에도 suggestion 넣어둘게
| val endTime: LocalDateTime, | ||
| val capacity: Int, | ||
| val workbookId: UUID, | ||
| val isWriter: Boolean, |
There was a problem hiding this comment.
Suggested change
| val isWriter: Boolean, | |
| val role: ParticipationType, |
Comment on lines
365
to
373
| return ReadSharedExamInfoResponse( | ||
| examId = examId, | ||
| title = sharedExam.title, | ||
| startTime = sharedExam.startTime, | ||
| endTime = sharedExam.endTime, | ||
| capacity = sharedExam.capacity, | ||
| workbookId = sharedExam.workbook.id, | ||
| isWriter = sharedExam.member.id == memberId, | ||
| ) |
There was a problem hiding this comment.
여기서 공유용 시험을 생성한 사람이 조회하는거면 응시자 id , name 도 넘겨줘야할 것 같아요!!
There was a problem hiding this comment.
클라에 정확히 머 필요한지 함 물어볼게!!
There was a problem hiding this comment.
오오오키오키
readExamResultDetail 이 기능 쓰려면 저 정보가 어딘가엔 응답으로 들어가야할 것 같아스 ~ ~
테스트 커버리지 측정
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
✨ 작업 내용
✨ 참고 사항
⏰ 현재 버그
✏ Git Close #256