Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: readAllSharedExams #255

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Feat: readAllSharedExams #255

merged 1 commit into from
Oct 19, 2024

Conversation

adorableco
Copy link
Contributor

PR

✨ 작업 내용

  • readAllSharedExams (사용자가 생성했거나, 응시한 공유용 시험 목록을 반환하는 기능) 을 구현했습니다.

✨ 참고 사항

  • examsAsCreator => 공유용 시험만 딱 조회를 하면 돼서 sharedExamRepository 를 생성하고 이 레포에서 조회를 했습니다.
  • examsAsExaminee => 이건 examResult를 먼저 조회하고 여기서 sharedExam에 대한 examResult만 추출했어야 했는데 처음엔 queryDSL 등으로 쿼리 선에서 추출을 마무리하고 싶었으나.... 멘토님이 제안해주신대로 일단 조회하고 필터링하는 것으로 구현했습니다.
  • workbook 까지 조회가 필요없는 경우라 exam 에서 workbook을 lazy fetching 하는 것으로 변경했습니다.
  • sharedExam의 시험 상태를 체크하는 메서드를 확장 함수로 구현했는데 이런건 테스트를 보통 어떻게 하는 편일까요? 멘토님께 나중에 물어보겠딤

⏰ 현재 버그

x


✏ Git Close

@adorableco adorableco added ✨ Feature 기능 개발 🫧 seyeon seyeon labels Oct 18, 2024
@adorableco adorableco self-assigned this Oct 18, 2024
@adorableco adorableco linked an issue Oct 18, 2024 that may be closed by this pull request
1 task
Copy link

테스트 커버리지 측정

File Coverage [43.96%] 🍏
Exam.kt 85.11% 🍏
ParticipationType.kt 0%
ExamStatus.kt 0%
Total Project Coverage 80.26% 🍏

@adorableco adorableco requested a review from RinRinPARK October 18, 2024 23:45
Copy link
Contributor

@RinRinPARK RinRinPARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했딤!👍🤩

@adorableco adorableco merged commit e936691 into develop Oct 19, 2024
1 check passed
@adorableco adorableco deleted the seyeon/swm-197 branch October 19, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🫧 seyeon seyeon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feat: readAllSharedExams
2 participants