Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: ReadExamResultDetail 구현 #253

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Feat: ReadExamResultDetail 구현 #253

merged 2 commits into from
Oct 14, 2024

Conversation

RinRinPARK
Copy link
Contributor

@RinRinPARK RinRinPARK commented Oct 14, 2024 •
edited
Loading

PR

✨ 작업 내용

  • readExamResultDetail 구현

✨ 참고 사항

  • 명세서 작성완료!
  • 기존에 readExamHistoryDetail 리턴값 중에 createdAt에 달려있던 주석을 제거 했습니다. (문제 풀이 생성일 리턴하는게 맞아서!!)
  • 테스트할 때, examId랑 memberId 적절한 값들을 잘 찾아 넣는게 좋습니다.. 중구난방인 데이터들이 많으요

⏰ 현재 버그

✏ Git Close #252

@RinRinPARK RinRinPARK added ✨ Feature 기능 개발 ☘️ surin surin labels Oct 14, 2024
@RinRinPARK RinRinPARK self-assigned this Oct 14, 2024
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

There is no coverage information present for the Files changed

Total Project Coverage 83.25% 🍏

@RinRinPARK RinRinPARK requested a review from adorableco October 14, 2024 10:00
adorableco
adorableco approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@adorableco adorableco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료여 ~~~ 👍👍🤩✨

src/main/kotlin/com/swm_standard/phote/dto/ExamDtos.kt Outdated

data class ReadExamResultDetailResponse(
val examId: UUID,
val memberId: UUID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val memberId: UUID,
val name: String,

여기 member id 대신 member 이름 담아주는거 어떨까영

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그게 낫겠다!! 바꿨시유

@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

There is no coverage information present for the Files changed

Total Project Coverage 83.25% 🍏

@RinRinPARK RinRinPARK merged commit a90bb0c into develop Oct 14, 2024
1 check passed
@RinRinPARK RinRinPARK deleted the rin/swm-196 branch October 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorableco adorableco adorableco approved these changes

Assignees

@RinRinPARK RinRinPARK

Labels
✨ Feature 기능 개발 ☘️ surin surin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Feat: readExamResultDetail
2 participants
@RinRinPARK @adorableco