Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: readExamResults 구현 #245

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Feat: readExamResults 구현 #245

merged 2 commits into from
Oct 6, 2024

Conversation

RinRinPARK
Copy link
Contributor

PR

✨ 작업 내용

  • readExamResults를 구현했습니다

✨ 참고 사항


⏰ 현재 버그


✏ Git Close #233

@RinRinPARK RinRinPARK added ✨ Feature 기능 개발 ☘️ surin surin labels Oct 6, 2024
@RinRinPARK RinRinPARK self-assigned this Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

테스트 커버리지 측정

There is no coverage information present for the Files changed

Total Project Coverage 83.02% 🍏

@RinRinPARK RinRinPARK requested a review from adorableco October 6, 2024 08:10
@@ -54,6 +56,7 @@ class ExamService(
@Value("\${openai.api.url}")
lateinit var url: String

@Transactional(readOnly = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스에 어노테이션 붙어있어서 기존대로 빼도 될 것 같아온

Comment on lines 37 to 41
data class ReadExamStudentResult(
val userId: UUID,
val name: String,
val score: Int,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 time (소요 시간) 들어가면 좋을 것 같네욘

@adorableco
Copy link
Contributor

굿~~~ 🙌🏻🙌🏻

Copy link

github-actions bot commented Oct 6, 2024

테스트 커버리지 측정

There is no coverage information present for the Files changed

Total Project Coverage 83.02% 🍏

@RinRinPARK RinRinPARK merged commit a3a1519 into develop Oct 6, 2024
1 check passed
@RinRinPARK RinRinPARK deleted the rin/swm-188 branch October 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 ☘️ surin surin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feat: readExamResults 구현
2 participants