Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Apple login 구현 #218

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Feat: Apple login 구현 #218

merged 2 commits into from
Sep 13, 2024

Conversation

RinRinPARK
Copy link
Contributor

@RinRinPARK RinRinPARK commented Sep 12, 2024 •
edited
Loading

PR

✨ 작업 내용

  • Apple login을 구현했습니다.

✨ 참고 사항

  • 프로퍼티 파일 로컬, 깃시크릿 모두 업데이트 했습니당당 노션 참고!
  • 테스트 방법은 슬랙 backend채널에 써둘게용
  • 나중에 프로퍼티 파일 속 redirect uri는 클라이언트 리다렉 주소로 변경해야댐

⏰ 현재 버그

✏ Git Close #215

@RinRinPARK RinRinPARK added ✨ Feature 기능 개발 ☘️ surin surin labels Sep 12, 2024
@RinRinPARK RinRinPARK self-assigned this Sep 12, 2024
@github-actions GitHub Actions
Copy link

테스트 커버리지 측정

There is no coverage information present for the Files changed

Total Project Coverage 83.99% 🍏

@adorableco
Copy link
Contributor

아주 잘되네요.~~~~~~~~ 굿굿 수고했어application.properties 에 sentry 는 더 이상 안쓸 것 같아서 없앴거든?? 배포는 secrets에 다 반영했고 로컬도 나중에 변경한걸로 바꿔잉~

@RinRinPARK RinRinPARK merged commit 0506fa6 into develop Sep 13, 2024
1 check passed
@RinRinPARK RinRinPARK deleted the rin/swm-178 branch September 13, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorableco adorableco adorableco approved these changes

Assignees

@RinRinPARK RinRinPARK

Labels
✨ Feature 기능 개발 ☘️ surin surin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Feat: AppleLogin 구현
2 participants
@RinRinPARK @adorableco