Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Google Login 구현 변경 #172

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Fix: Google Login 구현 변경 #172

merged 3 commits into from
Aug 8, 2024

Conversation

adorableco
Copy link
Contributor

@adorableco adorableco commented Aug 8, 2024 •
edited
Loading

PR

✨ 작업 내용

  • google login 작동 방식을 클라이언트에서 authorization code를 전달받아 사용자 정보를 반환하는 것으로 변경했습니다.

✨ 참고 사항

  • 구글에 요청할 때 들어가는 redirection url 이 처음 code를 요청할 때 보내는 redirection url과 다르면 invalid request 오류가 나는 것 같습니다. 그래서 지금은 REDIRECT_URI 를 클라이언트 로컬 주소로 설정해놨으나 배포 시에는 클라이언트 배포 도메인 주소로 변경해야할 것 같습니다!

📚 테스트 방법

⏰ 현재 버그

x

✏ Git Close

@adorableco
Fix: Google Login 구현 변경
ecd7c8f 
part of swm-147
related to: #168
@adorableco adorableco added 🛠️ Fix Something isn't working 🫧 seyeon seyeon labels Aug 8, 2024
@adorableco adorableco self-assigned this Aug 8, 2024
@adorableco adorableco linked an issue Aug 8, 2024 that may be closed by this pull request
🛠️ Fix: Google Login 구현 변경 #168
Closed
1 task
@adorableco adorableco requested a review from RinRinPARK August 8, 2024 05:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Unit Test Results

16 tests   16 ✔️  2s ⏱️
  6 suites    0 💤
  6 files      0 ❌

Results for commit 539f6d7.

♻️ This comment has been updated with latest results.

@adorableco
Fix: getKaKaoUserInfo 원복
e35c4d8 
part of swm-147
related to: #168
@adorableco adorableco marked this pull request as draft August 8, 2024 05:05
@adorableco adorableco marked this pull request as ready for review August 8, 2024 05:11
RinRinPARK
RinRinPARK approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@RinRinPARK RinRinPARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿드굿드용👍

@RinRinPARK RinRinPARK merged commit 7afe78c into develop Aug 8, 2024
2 checks passed
@RinRinPARK RinRinPARK deleted the seyeon/swm-147 branch August 8, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinRinPARK RinRinPARK RinRinPARK approved these changes

Assignees

@adorableco adorableco

Labels
🛠️ Fix Something isn't working 🫧 seyeon seyeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ Fix: Google Login 구현 변경
2 participants
@adorableco @RinRinPARK