-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Angular 17.x, suppress rfdc #1943
base: master
Are you sure you want to change the base?
Conversation
…anrideshark in pr swimlane#1763 (with rfdc, there is the same message like clone-deep: CommonJS or AMD dependencies can cause optimization bailouts)
…r/core@15 @angular-eslint/schematics@15 --force package.json: change package for angular to 15.2.9, suppress postinstall
…lls.ts) for angular 15 tsconfig.json: use ES2022 for target/module/lib for angular 15
…ts and karma.conf.js)
…e @angular-eslint/schematics --force
…@typescript-eslint/no-this-alias' for context = this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
is there an estimated release date for this fix? |
Also curious when the PR will be accepted |
Are there any news about this PR? |
Any news about this PR? |
@marjan-georgiev is this project still being maintained as it seems to have fallen behind, was hoping that this would have had been update to Angular 17 a while ago but now need it updating to Angular 18 |
What kind of change does this PR introduce? (check one with "x")
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:
Update package.json for angular 17.x
Suprress rfdc in boxchart. Package rfdc used in Replace deep clone #1771 generates the message : CommonJS or AMD dependencies can cause optimization bailouts.
My previous code in pr Update tsconfig and package for Angular 13 #1727 has no success. In this pr, code proposed by @bryanrideshark in pr Remove clone-deep dependency #1763 replace cloneDeep in box.component.ts
Fix: Drop dependency on rdfc? CommonJS dependency causes optimisation bailouts. #1901 and 19.1 triggers angular import warning: swimlane-ngx-charts.js depends on 'clone-deep'. CommonJS or AMD dependencies can cause optimization bailouts. #1688
Add PR add providedIn: 'root' #1861 to fix Lazy loading NgxChartsModules causes NullInjectorError #1733 (for Angular 17)
What is the new behavior?
Application runs on Angular 17.2.x
Does this PR introduce a breaking change? (check one with "x")
Other information:
Demo for 21.0.0 here:
https://inway.fr/ngx-charts