-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curve fitting on combo chart #1907
Open
kedij777
wants to merge
10
commits into
swimlane:master
Choose a base branch
from
kedij777:curve-fitting-line-chart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyq322
reviewed
Dec 24, 2023
projects/swimlane/ngx-charts/src/lib/line-chart/line-series.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/line-chart/line-series.component.ts
Outdated
Show resolved
Hide resolved
projects/swimlane/ngx-charts/src/lib/line-chart/line-series.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuqing Liu <[email protected]>
Co-authored-by: Yuqing Liu <[email protected]>
…mponent.ts Co-authored-by: Yuqing Liu <[email protected]>
…mponent.ts Co-authored-by: Yuqing Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Line chart on Combo chart lacks features like curve fitting and other linear styling.
Line Interpolation can't alter degree of curvature.
What is the new behavior?
Applied Linear interpolation to combo chart.
Added slidebar to Cardinal and Catmull Rom to change degree of curvature.
Does this PR introduce a breaking change? (check one with "x")