[6.1][PreCheckTarget] Consider UnresolvedSpecializeExpr a chain expression #77814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional chain and unresolved member chain should consider a generic specialization as a chain expression. rdar://140378864 (cherry picked from commit bee4cfe)
|
@swift-ci Please test |
DougGregor
approved these changes
Nov 22, 2024
anandfresh
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #77813 into
release/6.1Explanation: Fix a regression caused by #76981.
UnresolvedSpecializeExprshould be a part ofOptionalEvaluationExpr. This change fixes theOptionalEvaluationExprregression. Also this makes unresolved member chain expressions have ability to contain specialized nested types.Scope: Expression type checker
Risk: Low. The change is simple and targeted
Testing: Added regression test cases
Issuee: rdar://140378864
Reviewer: Pavel Yaskevich (@xedin)