Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifest #138

Merged
merged 4 commits into from
May 11, 2024
Merged

Add Privacy Manifest #138

merged 4 commits into from
May 11, 2024

Conversation

DivineDominion
Copy link
Contributor

Fixes #137

@DivineDominion
Copy link
Contributor Author

@Diggory @lardieri Can you folks maybe double-check I didn't break or overlook anything? Will test in app in the meantime.

Copy link
Contributor

@Diggory Diggory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@lardieri lardieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks good.

Apple is very quick to send the “we noticed one or more issues” email now. If you create a new app project, add the framework, upload the archive to TestFlight, and don’t get an email after five minutes — then I think you can say the test passes. :-)

@DivineDominion
Copy link
Contributor Author

Today, I've been stupid and tried with a macOS app -- where the Manifest isn't yet mandatory. So maybe I don't get an email at all. Will try with an iOS app later.

@DivineDominion DivineDominion merged commit 6aac7c1 into master May 11, 2024
1 check passed
@DivineDominion DivineDominion deleted the privacy-manifest branch May 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Privacy Manifest to SPM and Carthage and CocoaPods build
3 participants