-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with duplicate column name #136
Open
TomorrowMC
wants to merge
5
commits into
swiftcsv:master
Choose a base branch
from
TomorrowMC:fix-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−1
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
135fbf1
Fix issue with duplicate column name
TomorrowMC 67b115e
Fixed the problems and confirm the conformance
TomorrowMC d0839bf
Fixed the problems and confirm the conformance
TomorrowMC 07aab19
delete unused code and update the changelog
TomorrowMC 4bd5436
update the author info
TomorrowMC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// | ||
// Array+duplicates.swift | ||
// | ||
// | ||
// Created by 胡逸飞 on 2024/4/26. | ||
// | ||
|
||
extension Array where Element: Hashable { | ||
func duplicates() -> [Element] { | ||
let counts = self.reduce(into: [:]) { counts, element in counts[element, default: 0] += 1 } | ||
return counts.filter { $0.value > 1 }.map { $0.key } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// | ||
// DuplicateColumnNameHandlingTests.swift | ||
// | ||
// | ||
// Created by 胡逸飞 on 2024/4/27. | ||
// | ||
|
||
import Foundation | ||
import XCTest | ||
@testable import SwiftCSV | ||
|
||
class DuplicateColumnNameHandlingTests: XCTestCase { | ||
|
||
func testErrorOnDuplicateColumnNames() throws { | ||
let csvString = """ | ||
id,name,age,name | ||
1,John,23,John Doe | ||
2,Jane,25,Jane Doe | ||
""" | ||
|
||
XCTAssertThrowsError(try CSV<Named>(string: csvString)) { error in | ||
switch error as? CSVParseError { | ||
case .duplicateColumns(let columnNames): | ||
XCTAssertEqual(["name"], columnNames) | ||
default: | ||
XCTFail("Expected CSVParseError.duplicateColumns") | ||
} | ||
} | ||
} | ||
|
||
func testNoDuplicateColumnNames() throws { | ||
let csvString = """ | ||
id,name,age | ||
1,John,23 | ||
2,Jane,25 | ||
""" | ||
|
||
let csvError = try CSV<Named>(string: csvString) | ||
let csvRandom = try CSV<Named>(string: csvString) | ||
|
||
XCTAssertEqual(csvError.header, ["id", "name", "age"]) | ||
XCTAssertEqual(csvRandom.header, ["id", "name", "age"]) | ||
|
||
XCTAssertEqual(csvError.rows.count, 2) | ||
XCTAssertEqual(csvRandom.rows.count, 2) | ||
|
||
XCTAssertEqual(csvError.rows[0]["id"], "1") | ||
XCTAssertEqual(csvError.rows[0]["name"], "John") | ||
XCTAssertEqual(csvError.rows[0]["age"], "23") | ||
|
||
XCTAssertEqual(csvRandom.rows[0]["id"], "1") | ||
XCTAssertEqual(csvRandom.rows[0]["name"], "John") | ||
XCTAssertEqual(csvRandom.rows[0]["age"], "23") | ||
|
||
XCTAssertEqual(csvError.rows[1]["id"], "2") | ||
XCTAssertEqual(csvError.rows[1]["name"], "Jane") | ||
XCTAssertEqual(csvError.rows[1]["age"], "25") | ||
|
||
XCTAssertEqual(csvRandom.rows[1]["id"], "2") | ||
XCTAssertEqual(csvRandom.rows[1]["name"], "Jane") | ||
XCTAssertEqual(csvRandom.rows[1]["age"], "25") | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I believe this is dead code a.t.m. and we can remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, has fixed these problems