Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating project for strict concurrency and Swift 6 #207

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

kylebrowning
Copy link
Member

No description provided.

@kylebrowning kylebrowning requested a review from 0xTim August 20, 2024 18:29
Sources/APNSCore/APNSClient.swift Outdated Show resolved Hide resolved
Sources/APNSExample/Program.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Sources/APNS/APNSClient.swift Outdated Show resolved Hide resolved
.github/workflows/swift.yml Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Sources/APNS/APNSClient.swift Show resolved Hide resolved
Sources/APNSCore/APNSClient.swift Outdated Show resolved Hide resolved
@kylebrowning kylebrowning changed the title Updating project for stricture concurrency and Swift 6 Updating project for strict concurrency and Swift 6 Aug 20, 2024
@kylebrowning kylebrowning requested a review from 0xTim August 20, 2024 21:59
Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor points

Sources/APNS/APNSClient.swift Outdated Show resolved Hide resolved
Sources/APNSExample/Program.swift Show resolved Hide resolved
@kylebrowning kylebrowning requested a review from 0xTim August 21, 2024 14:11
Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kylebrowning kylebrowning merged commit 9b5032e into main Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants