Remove weather support and cleanup #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 705a56b. Only the bool member of the CrashSettings class was used. For simplification, use only the bool that was already used previously to store this setting.
QTranslation was not correctly installed anyway (goes out of scope before starting the application and only loads the german translation). i18n can be added later again.
The DBus server address selector tries to fetch the address from the command line parser. But the option was only added to the parser for CSwiftGuiStdApplications. This resulted in a log message from the parser.
ltoenning
force-pushed
the
remove_weather
branch
from
a37d082
to
cd007dd
Compare
ltoenning
force-pushed
the
remove_weather
branch
from
cd007dd
to
3c6a8c7
Compare
ltoenning
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our very limited development capacity, this will remove the weather engine support.
Weather support was not implemented for all simulators. Modern simulators like MSFS also provide pretty good integrated weather engines anyway.
If really wanted by some users, we could think about creating a standalone application from the weather engine source.