New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake support #220

Closed

ltoenning wants to merge 8 commits into main from cmake

Contributor

ltoenning commented Oct 25, 2023

Fixes #211

⚠️ Before going into a release version, this should be tested by some users beforehand.

ltoenning added the enhancement label

ltoenning requested a review from oktal3700

October 25, 2023 18:42

ltoenning self-assigned this

ltoenning force-pushed the cmake branch 2 times, most recently from 085415a to 40a00e0 Compare

October 26, 2023 08:19

ltoenning marked this pull request as ready for review

October 26, 2023 10:13

ltoenning force-pushed the cmake branch 3 times, most recently from 03dd3b5 to 6c7391d Compare

October 26, 2023 20:22

oktal3700 reviewed

View reviewed changes

scripts/build.py Outdated Show resolved Hide resolved

ltoenning force-pushed the cmake branch from 6c7391d to 79f7f4d Compare

October 27, 2023 05:22

oktal3700 force-pushed the cmake branch 4 times, most recently from f3ba8bd to 4f75b6b Compare

October 30, 2023 00:09

oktal3700 requested changes

View reviewed changes

Contributor

oktal3700 left a comment •

edited by ltoenning

Loading

I guess you intended to rename the unittests to remove the black prefix
There is one test which passes with qmake but is skipped with cmake: BlackCoreTest::CTestContext

oktal3700 reviewed

View reviewed changes

.gitignore Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

default.json Outdated Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

scripts/build.py Outdated Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

src/plugins/simulator/fs9/lobbyclient.h Outdated Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

src/plugins/simulator/fsxcommon/simconnectwindows.h Outdated Show resolved Hide resolved

oktal3700 reviewed

View reviewed changes

tests/blackmisc/CMakeLists.txt Outdated Show resolved Hide resolved

ltoenning added 3 commits

October 31, 2023 21:59


          Add missing include

eac7a5d


          Add missing header guard

8e8b079


          Use absolute path for sharedstatetestserver

7987a14

ltoenning force-pushed the cmake branch from 4f75b6b to 50530eb Compare

October 31, 2023 22:32

oktal3700 reviewed

View reviewed changes

.gitignore

Contributor

oktal3700 Nov 1, 2023

Seems like this should be squashed into a9abbf4

ltoenning added 2 commits

November 1, 2023 22:23


          Remove qmake files

3ffb8f6


          Add CMake support

e5ce5bc

ltoenning and others added 3 commits

November 1, 2023 22:23


          ci: Bump runner to windows-2022

89ce7a5


          ci: Cache downloaded Qt packages

30e3462


          ci: Cache the InstallBuilder installer

57e1718

ltoenning force-pushed the cmake branch from d90eff5 to 57e1718 Compare

November 1, 2023 21:24

Contributor Author

ltoenning commented Nov 12, 2023 •

edited

Loading

Merged with staging branch. 1deaeba
Fixed #211.

ltoenning closed this

ltoenning deleted the cmake branch

November 12, 2023 20:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels