-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build check natively in bazel #64
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Before we merge this we'll need to figure something out for aarch64-darwin and x86_64-darwin.
If we could figure out some way to fall back to continuing to use the cmake build on those platforms I think that would be fine for now.
@isaactorz updated description with PRs for gnss-converters and libswifnav. Note that some of the jobs got cancelled due to use of deprecated env images |
@isaactorz I've updated my libsbp PR to fall back to cmake build on mac. I've yet to successfully build libswiftnav and gnss-converters-private this way, but I leave that for tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me give this a quick build on the macs and then we can merge
The configuration has been copied from a CMake build that I ran in a container from a minimal Dockerfile:
Testing
libsbp ✅
libswiftnav-private ✅ (github actions are broken, but bazel stages passed)
gnss-converters-private ✅ (github actions are broken, but bazel stages passed)
JIRA
https://swift-nav.atlassian.net/jira/software/projects/BUILD/boards/227?selectedIssue=BUILD-645