cover CI hole which appears to be hiding a proc_macro bindgen bug #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrumley
changed the title
|
|
Nit: If there is a ticket for this change, it could be linked in the PR title |
sbmueller
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/algint-team
Prior to this PR, we only tested
cargo build --all-targets --all-featureson Linux machines. This seems to be a gap where inside of a proc-macro in theswiftnav-rswhich can fail on different OSes. After we take this PR we no longer will have this gap.Note, this is possibly not the best place to put this check, it may make more sense to have the ci, lint format run on a matrix instead.
API compatibility
Does this change introduce a API compatibility risk?
None
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
No
JIRA Reference
None