Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for MNIST handling and import it to main.py #43

Closed
wants to merge 2 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 13, 2023

Description

This PR adds a new Convolutional Neural Network (CNN) class for handling the MNIST dataset. The CNN class is implemented in a new file named cnn.py and is imported into main.py for use. This change replaces the existing feed-forward neural network (Net class) with a CNN, potentially improving performance on image data.

Summary of Changes

  • Created a new file src/cnn.py to contain the CNN class.
  • Added import statements for necessary modules in cnn.py.
  • Defined the CNN class in cnn.py, inheriting from nn.Module.
  • Implemented the layers and forward pass in the CNN class.
  • Added docstrings and comments to the CNN class and its methods.
  • Formatted and indented the code in cnn.py according to the rules specified in sweep.yaml.
  • Modified src/main.py to import the CNN class from cnn.py.
  • Replaced the instantiation of the Net class with an instantiation of the CNN class in the training loop of main.py.
  • Formatted and indented the code in main.py according to the rules specified in sweep.yaml.

Please review and merge this PR to incorporate the CNN class for improved handling of the MNIST dataset.

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/cnn.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot added the sweep label Oct 13, 2023
@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
1 participant