Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for MNIST classification and import it in main.py #29

Closed
wants to merge 2 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 12, 2023

Description

This PR adds a new CNN class for handling MNIST classification in the cnn.py file. The CNN class is designed to replace the existing feed-forward neural network (Net class) in main.py. The CNN architecture includes convolutional layers, pooling layers, and fully connected layers, making it suitable for image classification tasks like MNIST.

Summary of Changes

  • Created a new file src/cnn.py to define the CNN class.
  • Added the CNN class in cnn.py, which inherits from torch.nn.Module and includes the necessary layers for the CNN architecture.
  • Updated the main.py file to import the CNN class from cnn.py and use it for training.
  • Adjusted the training loop in main.py to work with the new CNN model.
  • Added docstrings and comments to the CNN class and its methods for clarity and maintainability.

Please review and merge this PR to incorporate the CNN class for improved MNIST classification.

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Rollback Files For Sweep

  • Rollback changes to src/cnn.py
  • Rollback changes to src/cnn.py
  • Rollback changes to src/main.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
0 participants