render/vulkan: Defer to renderpass clears when possible #3269
Conversation
Signed-off-by: Joshua Ashton <[email protected]>
|
cc @nyorain |
| renderer->render_pass_clear_color = clear_color; | ||
| renderer->pending_render_pass_clear = true; | ||
| } else { | ||
| vulkan_begin_renderpass(renderer, cb); |
There was a problem hiding this comment.
is this really needed? we only land here if renderer->in_render_pass == true in which case this call is a no-op right?
| @@ -490,7 +491,7 @@ static struct wlr_vk_render_buffer *create_render_buffer( | |||
| fb_info.width = dmabuf.width; | |||
| fb_info.height = dmabuf.height; | |||
| fb_info.layers = 1u; | |||
| fb_info.renderPass = buffer->render_setup->render_pass; | |||
| fb_info.renderPass = buffer->render_setup->render_pass_load; | |||
There was a problem hiding this comment.
I'd add a comment here stating that we can use either VkRenderPass since they are compatible due to only loadOp being different.
There was a problem hiding this comment.
Aside from the nitpicks this makes sense. It's just a workaround for the mismatch between efficient vulkan usage and the wlr api though and we should probably rather adjust the wlr api on the long run (allowing to optionally pass clear color and scissor rect to begin already, for instance).
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3269 |
Signed-off-by: Joshua Ashton [email protected]