chore: remove php role #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
force-pushed
the
chore/remove-php
branch
from
62b99c3 to
df7e1a0
Compare
SilasPeters
force-pushed
the
chore/remove-php
branch
from
df7e1a0 to
4b8bc3c
Compare
SilasPeters
force-pushed
the
chore/remove-php
branch
from
4b8bc3c to
de7dc6d
Compare
TobiasDeBruijn
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only does this remove php, it also makes it easier to recover this role by referring to this PR in
main.yml, which I propose we will do for all future role removals. You never know if we need any removed service again. Just plainly removing is a waste of knowledge which might not be found easily.TODO: remove
/var/www/phpmyadmin.svsticky.nlto prevent it from being included in backups on current host. (Must be done after merge)