Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added healthcheck to outline #469

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

SilasPeters
Copy link
Member

This PR aims to monitor the downage of Outline, by adding healthchecks to a custom image of outline.

In order to properly achieve this, the compose-up.yml tasks of the Docker role needed to be expanded to support rebuilding (outdated) images.

Closes #466

@SilasPeters SilasPeters force-pushed the feat/outline-healthcheck branch from ec585da to c971269 Compare August 28, 2024 21:22
@SilasPeters
Copy link
Member Author

Can't convert this to draft on mobile so here goes: outline recently fixed itself so the Docker file is redundant. Will simplify things

@SilasPeters
Copy link
Member Author

@stickyPiston pretty please? 🦫

@SilasPeters SilasPeters marked this pull request as draft November 18, 2024 19:02
@SamStaijen
Copy link

SamStaijen commented Dec 2, 2024

LGTM, did not test tho.

Edit: I see this is a draft. I have reverted my approval, please ping mw when done.

SamStaijen
SamStaijen previously approved these changes Dec 2, 2024
@SamStaijen SamStaijen self-requested a review December 2, 2024 18:25
@SilasPeters
Copy link
Member Author

LGTM, did not test tho.

Edit: I see this is a draft. I have reverted my approval, please ping mw when done.

I just finished it now, but I am not certain that my change will not affect the data stored. I will check on staging.

@SilasPeters SilasPeters marked this pull request as ready for review December 3, 2024 20:45
@SilasPeters
Copy link
Member Author

After you reviewed I reverted the changes to the line where it states to what path the storage-data named volume was mounted in the container. If I did not do so, all data would probably not be found on production and the board would lose temporarily lose access to the files. I guess you missed that in the review, but now it's done!

@SilasPeters SilasPeters removed the request for review from SamStaijen December 3, 2024 20:47
@SilasPeters SilasPeters requested review from SamStaijen and removed request for stickyPiston December 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give healthcheck.io or sentry access to Docker services
3 participants