Wildcard certs #387
Open
Wildcard certs #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMPORTANT: Merijn please run the proper roles for make sure it works xoxo |
|
This seems to fail for https://dev.svsticky.nl/ ( |
Mstiekema
force-pushed
the
wildcard-certs
branch
from
20fe909 to
5966b25
Compare
Nope, I only had to add the hostname as a seperate domain to the certbot command and poof it's working |
Mstiekema
force-pushed
the
wildcard-certs
branch
from
5966b25 to
706073a
Compare
|
TODO: Create a loop to request certs for
|
Riscky
reviewed
Jun 20, 2022
| --cert-name {{ item }} | ||
| --dns-digitalocean | ||
| --dns-digitalocean-credentials /etc/letsencrypt/certbot-creds.ini | ||
| --domain "*.{% if 'staging' in group_names %}dev.{% endif %}{{ item }}" |
There was a problem hiding this comment.
note: to make this work, every domain should get an extra domain record (dev.domainame pointing to the staging server).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! Very nice! I think everything is fixed with this, just have to run all the updated tasks to make sure all the subdomains are still working with the wildcard cert.
Maybe we can also destory a bit of the websites.yml with this PR? Who knows? Only time will tell..