Fix/near you overlay #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now it is working properly
…mainly for handling DOM element creation
SilasPeters
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
I do understand that refactoring strictly speaking isn't what this branch was made for, but refactoring unexpectedly solved my bug and I just went along and rewrote the whole thing because it was quite a mess.
Life is what happens while you're busy making other plans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this branch to fix the approximate address api calls to openstreetmap that were failing.
I looked into switching from XMLHttpRequests to fetch, which is more modern.
Switching to fetch 'magically' fixed the api call bug that I was having.
After that, I refactored all the overlay code to use fetch. Then refactored again by creating helper functions to make the code a lot more readable.
P.S.
I do understand that refactoring strictly speaking isn't what this branch was made for, but refactoring unexpectedly solved my bug and I just went along and rewrote the whole thing because it was quite a mess.