Database works, UI got an upgrade, authentication not done yet #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
force-pushed
the
BasicsWorking
branch
3 times, most recently
from
f94973d to
621d4bb
Compare
SilasPeters
requested changes
May 10, 2024
…e popup code cleaner and look nicer
…ation input isn't working yet
…omting happens too often
ArondenOuden
force-pushed
the
BasicsWorking
branch
from
621d4bb to
5c510b7
Compare
|
I will re-review this soon. Please refrain from pushing new features in this branch, for otherwise I will get in a endless review cycle. Although, your latest push was done by me haha |
SilasPeters
reviewed
May 31, 2024
SilasPeters
requested changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the existing project work locally.
Project now uses postgresql using psycopg2 in python which wasn't properly set up.
Now it should work if you install postgrsql on your machine and then you can view/edit your current database using PGAdmin 4.
Made the UI theme purple and added custom markers. Filled the pop-ups with content I found could be fun. I added the basics for 'spots' which are the amount of times a sticker has been spotted. It could be expanded by providing a photo (and maybe verifying each spot), but I now works with a simple button.
Added a 'Google Maps style' 'near you' content overlay thing. Still a bit of a work in progress but the general idea is working well.
The database connection works, but the authentication currently doesn't. I also (temporarily) made the stickers verified by default, as the admin page isn't working at the moment.