Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function to age at date #1143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

CloevVeller
Copy link

Added the function that checks the user's age at the time of the event in stead of at the time of enrollment

SilasPeters
SilasPeters previously approved these changes Dec 10, 2024
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work at first sight! However, our pipeline complains. You should see the logs of the pipeline. Perhaps some checks failed or your code does not match our style requirements.

@SilasPeters SilasPeters linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve the changes, but I want to test this beforehand (dates and timezones might give unexpected results). I'm quite busy though, so don't expect me to have done this in a day or two. Perhaps someone else could adjust (or expand?) the test suite to test this edge case (and, especially, if no one else unjustly can sign up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Age check activities not based on age at time of event
2 participants