Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enroll reservists #1033

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix enroll reservists #1033

wants to merge 2 commits into from

Conversation

Siem2l
Copy link
Contributor

@Siem2l Siem2l commented Oct 26, 2022

Hopefully fixes #855

@Mstiekema Mstiekema added hacktoberfest hacktoberfest-accepted This issue/PR has been accepted as a solution fitting for the hacktoberfest and removed hacktoberfest labels Oct 28, 2022
@SanderHageman
Copy link
Contributor

The issue is a bit 'vague' to me, and I haven't noticed it working incorrectly. Do the changes resolve the issue now?

@Siem2l
Copy link
Contributor Author

Siem2l commented Oct 3, 2023

The issue is a bit 'vague' to me, and I haven't noticed it working incorrectly. Do the changes resolve the issue now?

Not sure, we have had issues and this was a hopeful fix, but the issue overall seems to occur very rarely

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in this change, so I suggest we just merge this.

@Siem2l would you like to do the honor, or shall I do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hacktoberfest-accepted This issue/PR has been accepted as a solution fitting for the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enroll_reservists seems to randomly select participants
4 participants