-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sac points tracking system:tm: #1015
base: master
Are you sure you want to change the base?
Conversation
Commissions are missing entirely from this PR right now. Each commission should have their own SAC points for being a member of the commission. This was a quick review will do a bit more indepth later on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this PR!
In general it looks really good, well done :)
I left a few comments I'd like to see you address, but apart from that this looks quite ready to merge.
Let me know if you have questions about anything I wrote.
Depending on the exact implementation details of the committee points, this might be something for a later PR. |
I've held some initial talks for SAC and when Joris de Jong and I were talking about Koala implementatio, we also thought the comittees should not be in the MVP. This can easily be calculated if someone lets us know that they want their certificate. In principle students can calculcate it themselves. I think it's important to merge this PR asap, since the new year is around the corner. |
All requested changes are implemented and this PR only needs the sac categories to be filled out. Waiting for further actions now |
finally (will fix #918)