Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using secure block cipher mode #26

Closed
wants to merge 3 commits into from

Conversation

jlovison
Copy link
Contributor

@jlovison jlovison commented Jan 9, 2013

So I initially was only editing the random mode to the pyCrypto Crypto.Random.random method, when I noticed that the pycrypto defaults to ECB mode, which is sort of bad (I opened issue #27 which explains in a bit more detail why)

Rather than just offer a problem and not a solution, I edited the library to support better block cipher modes while retaining backwards compatibility, by allowing a field attribute block_type to be set, and using the better block ciphers only if that is set.

I also added a bit to the tests to test that this does in fact work as intended, and all existing tests pass.

I'd highly recommend a roadmap that eventually phases out the old behavior and makes the CBC mode default, but I figured invalidating everyone's data abruptly was a bad way to go about it.

Previous request:
The pyCrypto library includes a random method that's supposedly more "cryptographically secure" than the python random library.

I updated the imports to use this library instead of the python one.

@bltravis
Copy link
Collaborator

So, has this project been abandoned, or are these pull requests just being ignored?

@svetlyak40wt
Copy link
Owner

@bltravis I have no time to support it, but I can add you to this project's contributors, so you'll be able to push and merge pull requests. Do you want to become a project maintainer?

@bltravis
Copy link
Collaborator

Sure.

@svetlyak40wt
Copy link
Owner

Done

@bltravis
Copy link
Collaborator

Ok, I've already merged these changes into my fork, so they're rolled into pull request #24. I'm going to close this one and merge #24, which will kill two birds with one stone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants