Helm Template Changes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if there are CRDs out there that create deployments/pods and we want to save those as well so I'm not sure if we should limit to known resources or if it would be better to search for "images" instead. |
dbw7
force-pushed
the
helm-template-parsing
branch
from
40252f5 to
3358e20
Compare
atanasdinov
approved these changes
May 20, 2024
atanasdinov
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Update helm.go * updates based on feedback * add unit test
atanasdinov
added a commit
that referenced
this pull request
Jun 3, 2024
…objects when parsing Helm charts (#461) Helm Template Changes (#446) * Update helm.go * updates based on feedback * add unit test Co-authored-by: dbw7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #442
Putting this up for review but I don't plan to merge until I've tested some air-gapped cases to make sure everything is still working as expected.