Added ability to create OS users #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasdinov
reviewed
Nov 17, 2023
| {{ end }} | ||
|
|
||
| {{/* Root */}} | ||
| {{ if (eq .Username "root") }} |
There was a problem hiding this comment.
Is there a particular reason not to {{ else }} instead?
There was a problem hiding this comment.
Nothing specific. My head was in a different place editing a template v. code so I just wasn't thinking of it as a if/else construct so much as a flag for inclusion (not sure if that made sense).
Comment on lines
+13
to
+15
| {{ if .Password }} | ||
| echo '{{.Username}}:{{.Password}}' | chpasswd -e | ||
| {{ end }} |
There was a problem hiding this comment.
If this is the same for both cases can we extract it down below in order to avoid the repetition?
There was a problem hiding this comment.
IMO that makes it less readable, but that may be a personal distaste for the templating syntax. I like the model here where we have distinct section on root v. non-root and, IMO, that's worth the minimal duplication.
atanasdinov
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not include checks to ensure at least one of password/SSH key are specified per user. We likely want that (I can't think of a use case for manually creating a user that can't be logged in that we'd want to support here), but that'll wait until the larger validation infra is in place for the entire image definition.