Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image build workflow on prs and pushes #432

Merged
merged 1 commit into from
May 3, 2024

Conversation

fdegir
Copy link
Contributor

@fdegir fdegir commented May 2, 2024

This commit introduces a new workflow to attempt building EIB container image for prs and pushes to verify the image is buildable.

@fdegir fdegir requested review from e-minguez, jdob and hardys May 2, 2024 14:49
Copy link
Contributor

@jdob jdob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude, CI additions always make me happy :)

@e-minguez
Copy link
Contributor

e-minguez commented May 2, 2024

Just in case I had this in my own fork https://github.com/e-minguez/edge-image-builder/blob/build-container/.github/workflows/build-container.yml
This includes pushing the container image to the ghcr registry as well

In fact #237 but IIRC I closed it because there was no interest on having this at that time.

@fdegir
Copy link
Contributor Author

fdegir commented May 2, 2024

Just in case I had this in my own fork e-minguez#1 This includes pushing the container image to the ghcr registry as well

Didn't know you were looking into this as well @e-minguez.

Not having an image build check for prs/pushes made me add this so I added a simple one.
We could and should perhaps have a push/post-merge workflow based on yours to push built images and update this one later on.

@fdegir fdegir merged commit a7e9a9e into suse-edge:main May 3, 2024
3 checks passed
@fdegir fdegir deleted the build-image-workflow branch May 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants