Fix Helm chart OCI registry handling #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasdinov
reviewed
Apr 8, 2024
| @@ -197,6 +197,10 @@ func TestDownloadChart_FailedRegistryLogin(t *testing.T) { | |||
| helmChart := &image.HelmChart{} | |||
| helmRepo := &image.HelmRepository{ | |||
| URL: "oci://registry-1.docker.io/bitnamicharts/apache", | |||
| Authentication: image.HelmAuthentication{ | |||
There was a problem hiding this comment.
Can we add a test case without credentials?
There was a problem hiding this comment.
I would say this is covered in TestDownloadChart as it uses an OCI repository with no credentials while all of the other failure cases of downloadChart are covered.
There was a problem hiding this comment.
Not really. In fact we need to split up the cases where we:
- return
nilif there are credentials for successful operation - return error if there are credentials for failed operation
- panic if there aren't credentials since the function should then never be called
atanasdinov
approved these changes
Apr 8, 2024
e-minguez
pushed a commit
to e-minguez/edge-image-builder
that referenced
this pull request
Apr 9, 2024
* fix handling for oci registries * update release notes and test * add valid registry login case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355 .