Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm parse fix #310

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Helm parse fix #310

merged 4 commits into from
Mar 13, 2024

Conversation

dbw7
Copy link
Contributor

@dbw7 dbw7 commented Mar 13, 2024

Fixes #307

@dbw7 dbw7 requested a review from atanasdinov March 13, 2024 16:05
Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update release notes.

assert.Nil(t, resources)
}

func TestParseChartContents(t *testing.T) {
contents := `
# Source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a valid source string just for providing a "good" example?

@dbw7 dbw7 force-pushed the helm-parse-fix branch 2 times, most recently from 4214ecb to f781e52 Compare March 13, 2024 16:20
@dbw7 dbw7 merged commit f39a327 into suse-edge:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIB helm chart logic breaks if "---" is present in the chart's Kubernetes resources
2 participants