Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Helm Definition #288

Merged
merged 13 commits into from
Mar 11, 2024
Merged

New Helm Definition #288

merged 13 commits into from
Mar 11, 2024

Conversation

dbw7
Copy link
Contributor

@dbw7 dbw7 commented Mar 8, 2024

No description provided.

@dbw7 dbw7 requested review from atanasdinov and jdob March 8, 2024 22:16
Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the missing check when reading values from the repository map.

pkg/helm/helm.go Outdated Show resolved Hide resolved
pkg/helm/helm_test.go Outdated Show resolved Hide resolved
pkg/image/validation/kubernetes.go Outdated Show resolved Hide resolved
pkg/image/validation/kubernetes_test.go Outdated Show resolved Hide resolved
pkg/image/validation/kubernetes.go Outdated Show resolved Hide resolved
pkg/registry/helm.go Outdated Show resolved Hide resolved
Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes are not updated.

@dbw7 dbw7 requested a review from atanasdinov March 11, 2024 13:58
@dbw7 dbw7 force-pushed the helm-chart-def-new branch from 77ba27f to 528ca4e Compare March 11, 2024 17:16
pkg/image/validation/kubernetes.go Outdated Show resolved Hide resolved
@dbw7 dbw7 force-pushed the helm-chart-def-new branch from 528ca4e to 2b094e0 Compare March 11, 2024 17:26
@dbw7 dbw7 force-pushed the helm-chart-def-new branch from 61602ab to 7196aa8 Compare March 11, 2024 17:33
@dbw7 dbw7 merged commit 46fc5fd into suse-edge:main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants