Skip to content

Commit

Permalink
Extract configurable Helm chart repository variable (#338)
Browse files Browse the repository at this point in the history
* Extract chart repository variable

Signed-off-by: Atanas Dinov <[email protected]>

* Update release notes

Signed-off-by: Atanas Dinov <[email protected]>

---------

Signed-off-by: Atanas Dinov <[email protected]>
  • Loading branch information
atanasdinov authored Mar 28, 2024
1 parent 9e6e21a commit 247d676
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
## Bug Fixes

* [#319](https://github.com/suse-edge/edge-image-builder/issues/319) - Combustion fails when combustion directory content is larger than half of the RAM of the system
* [#233](https://github.com/suse-edge/edge-image-builder/issues/233) - Use different Helm chart sources for development and production builds

---

Expand Down
8 changes: 5 additions & 3 deletions pkg/combustion/helm.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package combustion

import "github.com/suse-edge/edge-image-builder/pkg/image"
import (
"github.com/suse-edge/edge-image-builder/pkg/env"
"github.com/suse-edge/edge-image-builder/pkg/image"
)

func ComponentHelmCharts(ctx *image.Context) ([]image.HelmChart, []image.HelmRepository) {
if ctx.ImageDefinition.Kubernetes.Version == "" {
Expand All @@ -9,7 +12,6 @@ func ComponentHelmCharts(ctx *image.Context) ([]image.HelmChart, []image.HelmRep

const (
suseEdgeRepositoryName = "suse-edge"
suseEdgeRepositoryURL = "https://suse-edge.github.io/charts"
installationNamespace = "kube-system"
)

Expand Down Expand Up @@ -39,7 +41,7 @@ func ComponentHelmCharts(ctx *image.Context) ([]image.HelmChart, []image.HelmRep

suseEdgeRepo := image.HelmRepository{
Name: suseEdgeRepositoryName,
URL: suseEdgeRepositoryURL,
URL: env.SUSEEdgeRepository,
}

repos = append(repos, suseEdgeRepo)
Expand Down
5 changes: 5 additions & 0 deletions pkg/env/env.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package env

var (
SUSEEdgeRepository = "https://suse-edge.github.io/charts"
)

0 comments on commit 247d676

Please sign in to comment.