Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use go mod, and minor fixes #1

Merged
merged 5 commits into from
Jan 5, 2021
Merged

use go mod, and minor fixes #1

merged 5 commits into from
Jan 5, 2021

Conversation

houz42
Copy link
Member

@houz42 houz42 commented Jan 5, 2021

  • use go mod
  • fix format placeholders
  • complete controller interface (with empty implementation)

same as Huawei#13

@houz42 houz42 requested a review from ddddx0 January 5, 2021 06:00
ddddx0
ddddx0 approved these changes Jan 5, 2021
View reviewed changes
Copy link

@ddddx0 ddddx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@houz42 houz42 merged commit 8c96ed7 into supremind:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddddx0 ddddx0 ddddx0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houz42 @ddddx0