feat: oauth provider #549
Open
feat: oauth provider #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Dec 17, 2024
| def redirect(self, url: str) -> BaseResponse: | ||
| if not self.response_sent: | ||
| self.set_header("Location", url) | ||
| self.set_status_code(302) |
There was a problem hiding this comment.
doesn't this need to set response_sent?
| def redirect(self, url: str) -> BaseResponse: | ||
| if not self.response_sent: | ||
| self.set_header("Location", url) | ||
| self.set_status_code(302) |
There was a problem hiding this comment.
doesn't this need to set response_sent?
| try: | ||
| session = await get_session( | ||
| api_options.request, | ||
| False, |
There was a problem hiding this comment.
I'd prefer if this was a named param, but it doesn't matter too much.
| authorization_header = api_options.request.get_header("authorization") | ||
|
|
||
| if authorization_header is None or not authorization_header.startswith("Bearer "): | ||
| api_options.response.set_header( |
There was a problem hiding this comment.
I think this needs to be ported to node
|
|
||
| # Verify token signature using session recipe's JWKS | ||
| session_recipe = SessionRecipe.get_instance() | ||
| matching_keys = get_latest_keys(session_recipe.config, access_token_obj.kid) |
There was a problem hiding this comment.
this goes through caching right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR