Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server error when redirect_uri_info is not passed in the sign_in_up API #456

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

IamMayankThakur
Copy link
Contributor

@IamMayankThakur IamMayankThakur commented Oct 24, 2023

Summary of change

Fixed server error when the sign in up API was called using oAuthTokens without passing the redirect_uri_info.

Related issues

Test Plan

Added unit test

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

@IamMayankThakur IamMayankThakur force-pushed the fix/signin_up-invalid-redirect-uri-server-err branch from 2e0c6e4 to 553a621 Compare October 24, 2023 07:51
@IamMayankThakur IamMayankThakur changed the base branch from master to 0.16 October 24, 2023 07:55
@rishabhpoddar rishabhpoddar merged commit 00314bf into 0.16 Oct 24, 2023
5 of 7 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/signin_up-invalid-redirect-uri-server-err branch October 24, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants