Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validate_access_token function to providers #453

Merged
merged 10 commits into from
Oct 5, 2023

Conversation

IamMayankThakur
Copy link
Contributor

Summary of change

Added validate_access_token function to providers so that the access token received from providers can be verified.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

  • Added test for the case when validate_access_token raises an Exception.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

* Added `validate_access_token` function to providers, to allow verifying the access token received from the providers.
@IamMayankThakur IamMayankThakur changed the base branch from master to 0.16 October 4, 2023 12:09
CHANGELOG.md Show resolved Hide resolved
tests/thirdparty/test_thirdparty.py Outdated Show resolved Hide resolved
supertokens_python/recipe/thirdparty/providers/custom.py Outdated Show resolved Hide resolved
supertokens_python/recipe/thirdparty/providers/github.py Outdated Show resolved Hide resolved
supertokens_python/recipe/thirdparty/providers/github.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@@ -1,4 +1,4 @@
from typing import Any, Dict, Optional
from typing import Any, Dict, Optional, Tuple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what version is Tuple supported in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhpoddar rishabhpoddar merged commit 6e71e91 into 0.16 Oct 5, 2023
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/access-token-validation branch October 5, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants