fix: Handle AWS public urls separately when extracting TLDs #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add 429 rate limting from SaaS for v0.14
test: Fix failing test for the 0.14 patch release
KShivendu
force-pushed
the
fix/tldextract
branch
from
2b57cd2 to
00a5ae0
Compare
KShivendu
changed the title
KShivendu
changed the title
rishabhpoddar
suggested changes
Sep 18, 2023
rishabhpoddar
suggested changes
Sep 19, 2023
supertokens_python/utils.py
Outdated
Comment on lines
305
to
308
| if hostname.endswith(".amazonaws.com"): | ||
| # tldextract.extract() isn't able to parse AWS service public urls | ||
| return "amazonaws.com" | ||
|
|
There was a problem hiding this comment.
undo this and upgrade the lib
KShivendu
force-pushed
the
fix/tldextract
branch
from
cde073c to
077ff3b
Compare
|
Closing this in favour of #449. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Handle AWS public url separately when extracting TLDs
Related issues
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the core