Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker stderr #26

Open
wants to merge 2 commits into
base: 1.13
Choose a base branch
from
Open

Docker stderr #26

wants to merge 2 commits into from

Conversation

yowayb
Copy link

@yowayb yowayb commented Jan 23, 2022

Summary of change

When running in a container without $ERROR_LOG_PATH specified, this change will now print errors to stderr (instead of being merged into stdout)

Related issues

Test Plan

  1. Run container with incorrect port: sudo docker run --network="host" -p 3567:3567 -e POSTGRESQL_HOST="127.0.0.1" -e POSTGRESQL_PORT="5555" supertokens 2> >(while read line; do echo -e "\e[01;31m$line\e[0m" >&2; done)
  2. Confirm error in red
    image

Documentation changes

None

Checklist for important updates

  • Changelog has been updated
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

None

@yowayb
Copy link
Author

yowayb commented Jan 23, 2022

Should the Hikari errors go to stderr as well?

@yowayb yowayb marked this pull request as ready for review January 23, 2022 14:04
@rishabhpoddar
Copy link
Contributor

Should the Hikari errors go to stderr as well?

Yes. Any errors should go to stderr. Any particular reason why you think Hikari errors should not?

@yowayb
Copy link
Author

yowayb commented Jan 23, 2022

No reason; I just missed them. Will include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants